fix(sdk): use java duration for command request timeouts#928
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58509092e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e07b9fde00
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
java.time.Durationas the primary command timeout type for the Kotlin sandbox SDK.kotlin.time.Durationoverloads forRunCommandRequest,RunInSessionRequest, and theCommands.runInSession(...)convenience API so existing Kotlin builder-style callers can migrate gradually.toMillis()while keeping the wire timeout value in milliseconds.1.0.11to1.0.12.Testing
cd sdks/sandbox/kotlin && ./gradlew :sandbox:testcd sdks/sandbox/kotlin && ./gradlew spotlessCheckCompatibility
java.time.Durationdirectly for command timeouts.kotlin.time.Durationto the supported overloads continue to compile, but those overloads are deprecated in favor ofjava.time.Duration.request.timeoutnow receivesjava.time.Duration?instead ofkotlin.time.Duration?and may need a small migration.Checklist