Skip to content

(feat): tensorboard log in new executor. #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PanAndy merged 1 commit into from
Apr 29, 2026
Merged

(feat): tensorboard log in new executor. #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions roll/utils/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from concurrent import futures
import json
from functools import wraps
from typing import Optional, Dict, Any
Expand Down Expand Up @@ -77,9 +78,9 @@ def __init__(self, config: dict, **kwargs):
self.config[k] = str(self.config[k])
self.writer.add_hparams(hparam_dict=self.config, metric_dict={})
self.writer.flush()
self.executor = futures.ThreadPoolExecutor(max_workers=1)

@strip_at_tag_in_log
def log(self, values: dict, step: Optional[int], **kwargs):
def _write(self, values: dict, step: Optional[int], **kwargs):
for k, v in values.items():
if isinstance(v, (int, float)):
self.writer.add_scalar(k, v, global_step=step, **kwargs)
Expand All @@ -89,7 +90,12 @@ def log(self, values: dict, step: Optional[int], **kwargs):
self.writer.add_scalars(k, v, global_step=step, **kwargs)
self.writer.flush()

@strip_at_tag_in_log
def log(self, values: dict, step: Optional[int], **kwargs):
self.executor.submit(self._write, values, step, **kwargs)

def finish(self):
self.executor.shutdown(wait=True)
self.writer.close()


Expand Down
Loading