Skip to content

Replace deprecated set-state set-output GitHub Action's commands#2973

Merged
sczyh30 merged 2 commits into
alibaba:masterfrom
kirklin:patch-1
Nov 28, 2022
Merged

Replace deprecated set-state set-output GitHub Action's commands#2973
sczyh30 merged 2 commits into
alibaba:masterfrom
kirklin:patch-1

Conversation

@kirklin
Copy link
Copy Markdown
Contributor

@kirklin kirklin commented Nov 25, 2022

Describe what this PR does / why we need it

The save-state, set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added the area/ci Issues or PRs related to CI label Nov 25, 2022
Comment thread .github/workflows/ci.yml Outdated
uses: actions/setup-java@v3
with:
java-version: ${{ matrix.java }}
distribution: 'zulu'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's more common to use adopt (AdoptOpenJDK Hotspot)?

@kirklin kirklin requested review from sczyh30 and removed request for sczyh30 November 25, 2022 14:10
Copy link
Copy Markdown
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 0df2e20 into alibaba:master Nov 28, 2022
@sczyh30
Copy link
Copy Markdown
Member

sczyh30 commented Nov 28, 2022

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues or PRs related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants