Fix unit test testEmitSingleLongTimeRt() in MonoSentinelOperatorInteg…#3070
Open
LiYangSir wants to merge 1 commit into
Open
Fix unit test testEmitSingleLongTimeRt() in MonoSentinelOperatorInteg…#3070LiYangSir wants to merge 1 commit into
LiYangSir wants to merge 1 commit into
Conversation
sczyh30
reviewed
Mar 23, 2023
| @Test | ||
| public void testEmitSingleLongTimeRt() { | ||
| String resourceName = createResourceName("testEmitSingleLongTimeRt"); | ||
| // Warmup once |
Member
There was a problem hiding this comment.
Could you please illustrate why we need a warmup here in the code comment?
LiYangSir
force-pushed
the
fix_mono_rt_unit_test
branch
from
c239146 to
b681790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix unit test testEmitSingleLongTimeRt() in MonoSentinelOperatorIntegrationTest.
Does this pull request fix one issue?
Fixes #2974
Describe how you did it
Do a warm-up before invoke testEmitSingleLongTimeRt() to ensure that the test results meet expectations.
Describe how to verify it
Whether run the test on its own or the test class, the result of avgRt() is almost the same.
Special notes for reviews
NONE