feat(agent-sec-core)!: add security middleware framework with unified CLI entry point#121
Merged
edonyzpc merged 5 commits intoalibaba:release/agent-sec-core/v0.3from Apr 14, 2026
Conversation
6106d9a to
66d3f5d
Compare
d2f748e to
1dd5fd6
Compare
1dd5fd6 to
7bdab5d
Compare
7bdab5d to
771bafe
Compare
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
yangdao479
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
yangdao479
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
[NIT] 其他模块e2e测试也要有,需要模块owner补充(重要不紧急)
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
edonyzpc
reviewed
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
unify-cli还要考虑一个场景支持(可以后续PR):
- 支撑cosh/openclaw等agent的时候涉及到hook管理、安装,这里我们需要考虑提供不同agent的安装命令行。
- 同时考虑tracing agent sec core的记录hook安装调用记录
yangdao479
reviewed
Apr 14, 2026
yangdao479
reviewed
Apr 14, 2026
yangdao479
reviewed
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
Hi, thanks for the excellent contribution so far! As we refine this, I have a few thoughts:
- Could we implement a check to detect if specific submodules (like loongshield) are present? This is crucial for compatibility with various dependency-based OS setups.
- I noticed the command for agent-sec-core is missing the
--config agentos_baselineflag, which is required for Agentic-OS support. - Reflecting on these requirements, I wonder if binding commands directly in the backends is sustainable long-term. With loongshield separating its components, this approach might introduce redundancy. It might be worth rethinking the design to avoid duplicate logic.
Collaborator
@yangdao479 这个你来给出 draft 吧, @RemindD 先不关注工程类问题 |
Collaborator
那么这个pr在功能性上没有其他问题后,可以先合入,我后续再提交一些refactor的pr |
Collaborator
|
The asset_verify refactoring looks good to me. |
a961287
into
alibaba:release/agent-sec-core/v0.3
7 of 9 checks passed
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a layered security middleware architecture that routes all agent-sec-core operations through a unified
agent-sec-cli.pyentry point, ensuring every security action is logged as a structured JSONL event.Key additions:
Backends:
Includes comprehensive unit tests for all new modules and updated skill documentation to enforce routing through agent-sec-cli.py.
Related Issue
closes #108
Type of Change
Scope
cosh(copilot-shell)agent-sec-coreos-skillsagentsightChecklist
cosh: Lint passes, type check passes, and tests passagent-sec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpassagent-sec-core(Python): Ruff format and pytest passos-skills: Skill directory structure is valid and shell scripts pass syntax checkpackage-lock.json/Cargo.lock)Testing
python unit tests added and passed. Manually ran sec-core and found below records in the log file:
{"event_id": "c7dc49a7-3dba-4cd9-8350-9a27f48dbea2", "event_type": "sandbox_prehook", "category": "sandbox", "timestamp": "2026-04-07T03:06:15.543623+00:00", "trace_id": "2d9f2bc3-8069-4de9-a033-a7e2984abc20", "pid": 218434, "uid": 0, "session_id": null, "details": {"request": {"decision": "sandbox", "command": "rm -rf /root/working/anolisa/a.txt", "reasons": "递归/强制删除", "network_policy": "restricted", "cwd": "/root/working/anolisa"}, "result": {"decision": "sandbox", "command": "rm -rf /root/working/anolisa/a.txt", "reasons": "递归/强制删除", "network_policy": "restricted", "cwd": "/root/working/anolisa"}}}
{"event_id": "2452dc63-6e7f-4a64-8999-88d5b360edc6", "event_type": "verify", "category": "asset_verify", "timestamp": "2026-04-07T02:07:59.634517+00:00", "trace_id": "4ec0bac1-38ee-4632-b863-665b3552a9c9", "pid": 205806, "uid": 0, "session_id": null, "details": {"request": {"skill": null}, "result": {"passed": 0, "failed": 0}}}
{"event_id": "6fe3b1ef-b6fd-454a-b915-bccf243c0e0f", "event_type": "harden", "category": "hardening", "timestamp": "2026-04-09T04:54:14.330033+00:00", "trace_id": "43a8dc1d-4191-4998-a4ab-762597428f0d", "pid": 240596, "uid": 0, "session_id": null, "details": {"request": {"mode": "scan", "config": "agentos_baseline"}, "result": {"mode": "scan", "config": "agentos_baseline", "failures": [{"rule_id": "fs.shm_noexec", "status": "FAIL", "message": "/dev/shm must be mounted noexec to prevent in-memory code execution - Reason: /dev/shm is not mounted with noexec. (actual: --"}], "fixed_items": [], "passed": 22, "fixed": 0, "failed": 1, "manual": 0, "dry_run_pending": 0, "total": 23}}}
{"event_id": "90b55581-c1ed-4ac7-b3a9-8159206bcdf2", "event_type": "harden", "category": "hardening", "timestamp": "2026-04-09T04:54:27.836636+00:00", "trace_id": "d82d1d99-9921-4bf5-bd17-5bb65005e13a", "pid": 240799, "uid": 0, "session_id": null, "details": {"request": {"mode": "reinforce", "config": "agentos_baseline"}, "result": {"mode": "reinforce", "config": "agentos_baseline", "failures": [], "fixed_items": [{"rule_id": "fs.shm_noexec", "status": "FAIL", "message": "/dev/shm must be mounted noexec to prevent in-memory code execution - Reason: /dev/shm is not mounted with noexec. (actual: --"}], "passed": 22, "fixed": 1, "failed": 0, "manual": 0, "dry_run_pending": 0, "total": 23}}}
Additional Notes