fix(cosh): restore bash option after canceling from provider screen#393
Merged
samchu-zsl merged 1 commit intoalibaba:mainfrom Apr 28, 2026
Merged
Conversation
- Restore showBashOptionInAuthDialog to startup value
in cancelAuthentication and openAuthDialog
- Add tests for both startup=true and startup=false cases
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user enters the Custom Provider screen without making changes and
presses Escape to go back, the "Continue to Bash" option disappears from
the authorization dialog. The root cause is that
cancelAuthenticationunconditionally sets
showBashOptionInAuthDialogtofalse. The fixrestores it to its initial value (
showBashOptionOnStartup) so the bashoption reappears after cancellation. The same fix is applied to
openAuthDialog.Related Issue
fixes #385
Type of Change
Scope
cosh(copilot-shell)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)Checklist
cosh: Lint passes, type check passes, and tests passsec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpasspackage-lock.json/Cargo.lock)Testing
make format— passesnpm run lint:ci— passesmake test— 396 files, 7278 tests all passAdditional Notes
Changes:
useAuth.ts(fix) +useAuth.test.ts(new tests)