fix: avoid NPE in trustedLookup on environments without IMPL_LOOKUP, for issue #4011#7633
Open
fix: avoid NPE in trustedLookup on environments without IMPL_LOOKUP, for issue #4011#7633
Conversation
…for issue #4011 On Android, the static initializer leaves IMPL_LOOKUP null because the Unsafe-based access to MethodHandles.Lookup.IMPL_LOOKUP is gated to !ANDROID. trustedLookup(Class) then NPE'd at IMPL_LOOKUP.in(...), producing the user-visible "Attempt to invoke virtual method MethodHandles$Lookup.in(...) on a null object reference" when parsing Kotlin data classes via JSON.parseObject on Android 16 (API 36). - JDKUtils.trustedLookup: short-circuit and return null when IMPL_LOOKUP is unavailable. Most existing callers already wrap usage in try/catch and fall back to reflection-based access, so a null Lookup is the cleanest signal. - ObjectReaderCreator.lambdaSetter / createBuildFunctionLambda: handle the null Lookup explicitly and return null so callers fall back to reflection instead of throwing JSONException("create fieldReader error").
|
wenshao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JDKUtils.IMPL_LOOKUPnull (the Unsafe-based access toMethodHandles.Lookup.IMPL_LOOKUPis intentionally gated to!ANDROID).trustedLookup(Class)then NPE'd atIMPL_LOOKUP.in(...), producing the user-visible "Attempt to invoke virtual methodMethodHandles$Lookup.in(...)on a null object reference" when parsing Kotlin data classes viaJSON.parseObjecton Android 16 (API 36).JDKUtils.trustedLookup: short-circuit and returnnullwhenIMPL_LOOKUPis unavailable. Most existing callers already wrap usage intry/catchand fall back to reflection-based access, so a nullLookupis the cleanest signal.ObjectReaderCreator.lambdaSetter/createBuildFunctionLambda: handle the null lookup explicitly and return null so callers fall back to reflection instead of throwingJSONException(\"create fieldReader error\").Fixes #4011.
Test plan
JDKUtilsTest(usestrustedLookupwith non-nullIMPL_LOOKUP) still passes.ObjectReaderCreator*Test*,LambdaSetterTest*— all 38 tests pass.