sunfeiyu/fix-enable-property-bug-on-log-trigger#473
Merged
tanhe123 merged 2 commits intoSep 29, 2019
Merged
Conversation
vangie
reviewed
Sep 29, 2019
| functionParameter: logConfig.FunctionParameter || {} | ||
| }, | ||
| Enable: triggerProperties.Enable || true | ||
| Enable: (triggerProperties.Enable === false) ? false : true |
Contributor
There was a problem hiding this comment.
triggerProperties.Enable !== true
Contributor
There was a problem hiding this comment.
triggerProperties.Enable 是来自于 yaml 么？
如果想兼容 true 和 'true' 这两种情况，可以参考
https://stackoverflow.com/a/57923478
!!triggerProperties.Enable === true
Collaborator
Author
There was a problem hiding this comment.
1.triggerProperties.Enable !== true 时，属性为为空时，表达式的值为 false 不符合预期（预期是：不填写时默认为 true）
2. 不需要做到兼容，因为 fun 有 schema 的校验，当 Enable 属性为非 布尔 型时，会抛出错误。
Contributor
There was a problem hiding this comment.
(triggerProperties.Enable === false) ? false : true
等价于
!(triggerProperties.Enable === false)
vangie
suggested changes
Sep 29, 2019
| functionParameter: logConfig.FunctionParameter || {} | ||
| }, | ||
| Enable: triggerProperties.Enable || true | ||
| Enable: (triggerProperties.Enable === false) ? false : true |
Contributor
There was a problem hiding this comment.
triggerProperties.Enable 是来自于 yaml 么？
如果想兼容 true 和 'true' 这两种情况，可以参考
https://stackoverflow.com/a/57923478
!!triggerProperties.Enable === true
vangie
approved these changes
Sep 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log 触发器，fun deploy 时 Enable 开关属性没有生效。