feat(Version Check): Support disable fun version check#548
Merged
Conversation
vangie
approved these changes
Oct 22, 2019
tanhe123
reviewed
Oct 22, 2019
| const notifier = require('update-notifier'); | ||
| const pkg = require('../package.json'); | ||
|
|
||
| const FUN_DISABLE_VERSION_CHECK = 'FUN_DISABLE_VERSION_CHECK'; |
Comment on lines
+8
to
+13
| const disableVersionCheck = process.env[FUN_DISABLE_VERSION_CHECK]; | ||
| if ( | ||
| disableVersionCheck !== undefined && | ||
| disableVersionCheck !== '0' && | ||
| disableVersionCheck !== 'false' | ||
| ) { |
Contributor
There was a problem hiding this comment.
没写成 if (disableVersionCheck) ，是有啥特殊考虑？
tanhe123
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
提供
FUN_DISABLE_VERSION_CHECK环境变量，当设置了该环境变量并且值不为'0'或'false'时，不进行 fun 版本检测提示