add custom domain support#78
Merged
Merged
Conversation
|
|
tanhe123
reviewed
Sep 20, 2018
| 'type': 'object', | ||
| 'patternProperties': { | ||
| '^[a-zA-Z_][a-zA-Z0-9_-]{0,127}$': { | ||
| '^/': { |
| console.log(green(`table store ${name} deploy success\n`)); | ||
| } else if (resource.Type === 'Aliyun::Serverless::Log') { | ||
| // ignore, done by deployLogs | ||
| } else if (resource.Type === 'Aliyun::Serverless::CustomDomain') { |
Contributor
There was a problem hiding this comment.
如果 customDomain 在 service 之前，会存在 service 还没创建的情况，所以这里可以参考上面的 await deployLogs(tpl.Resources)，保证 customDomain 的逻辑在 service 之后
| protocol, | ||
| routeConfig | ||
| }) { | ||
| const fc = await getFcClient(); |
Contributor
There was a problem hiding this comment.
package.json 中的 @alicloud/fc2 的版本需要更新为 2.0.5
CiCi503
force-pushed
the
add_custom_domain_support
branch
from
6a9a0e4 to
87f656f
Compare
CiCi503
force-pushed
the
add_custom_domain_support
branch
from
87f656f to
dbe5eb2
Compare
tanhe123
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add custom domain support