[Test] Complete TODO assertion in NamingUtilsTest for valid clusterName case #14864
Unanswered
Sunwenzhi58
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Background
In
NamingUtilsTest, methodtestBatchCheckInstanceIsLegalcontains a TODO comment:api/src/test/java/com/alibaba/nacos/api/naming/utils/NamingUtilsTest.javavalid clusterNameThis test path currently executes but has weak assertion style and can be improved for readability and maintainability.
Proposal
Refine the TODO section to use clearer assertion style and ensure the valid clusterName path is explicitly validated.
Scope:
Why this helps
Plan
testBatchCheckInstanceIsLegalmvn -pl api -Dtest=NamingUtilsTest testAll reactions