Replies: 1 comment
|
Yes, gprc looks like a typo for grpc. It is not only a directory spelling at this point, though: the current client tree uses gprc consistently in the Java package path and in references such as NamingGrpcClientProxy and the redo classes. Renaming only the directory would make the source path and package declaration disagree. A complete correction would need to update, atomically:
The safest change would be a mechanical git mv from gprc to grpc followed by a repository-wide search for the old token and the client module tests. Because these are under the client implementation package, the rename may also affect users who imported an internal class directly, even though that is not normally a supported API. It is therefore worth checking whether the project is willing to take that compatibility change in the current release line or defer it to a major version. The current path confirms that the typo is present in the implementation rather than only in the web UI: |
Uh oh!
There was an error while loading. Please reload this page.
https://github.com/alibaba/nacos/tree/develop/client/src/main/java/com/alibaba/nacos/client/naming/remote。
这个目录下面,现在有gprc + http。 按理不应该命名为grpc + http 吗?
All reactions