feat: add label for self-hosted runner in neug-test#199
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoAdd daily label to self-hosted runners and LDBC benchmark workflow
WalkthroughsDescription• Add daily label to self-hosted runners across multiple workflows • Create new LDBC SNB Benchmark workflow for scheduled performance testing • Standardize runner labels for build and test jobs Diagramflowchart LR
A["Workflows"] --> B["Add daily label"]
A --> C["New LDBC Benchmark"]
B --> D["build-extensions.yml"]
B --> E["neug-extension-test.yml"]
B --> F["neug-test.yml"]
B --> G["wheels-common.yml"]
C --> H["ldbc-benchmark.yml"]
H --> I["Scheduled Testing"]
I --> J["Load Dataset"]
I --> K["Run Benchmark"]
File Changes1. .github/workflows/build-extensions.yml
|
Code Review by Qodo
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+26
to
+32
| - name: Build NeuG Python package | ||
| working-directory: tools/python_bind | ||
| run: | | ||
| export BUILD_HTTP_SERVER=ON | ||
| export WITH_MIMALLOC=ON | ||
| make build | ||
|
|
There was a problem hiding this comment.
2. Build without requirements install 🐞 Bug ☼ Reliability
The new ldbc-benchmark.yml runs make build for tools/python_bind without installing its Python requirements first, so the build/runtime can fail due to missing dependencies (e.g., Flask is in requirements.txt while make build does not install requirements).
Agent Prompt
### Issue description
`ldbc-benchmark.yml` runs `make build` in `tools/python_bind` without first installing `requirements.txt`/`requirements_dev.txt`. Since `make build` doesn’t install dependencies, the job may fail depending on runner state.
### Issue Context
The repo’s `tools/python_bind/Makefile` separates `requirements` from `build`, and requirements include runtime deps like `Flask`.
### Fix Focus Areas
- .github/workflows/ldbc-benchmark.yml[26-32]
- tools/python_bind/Makefile[7-25]
- tools/python_bind/requirements.txt[1-11]
### Proposed fix
In the "Build NeuG Python package" step, run `make requirements` (or explicitly `python3 -m pip install -r requirements.txt -r requirements_dev.txt`) before `make build`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201