refactor: Remove wal_uri from config and remove dummy work_dir parameter#230
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
liulx20
approved these changes
Apr 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies and standardizes how the Write-Ahead Log (WAL) directory is handled throughout the codebase. The main changes remove the
wal_uriconfiguration fromNeugDBConfig, eliminate theparse_wal_urifunction, and update related interfaces and method signatures to use a directwal_dirapproach. This reduces configuration complexity and potential sources of error related to WAL path resolution.Configuration Simplification
wal_urifield and related logic fromNeugDBConfig, so WAL directory handling is now standardized and no longer configurable via template strings. [1] [2] [3]parse_wal_urifunction and all calls to it, removing support for{GRAPH_DATA_DIR}template expansion. [1] [2]Interface and Method Updates
SessionLocalContext,SessionPool, andUpdateTransactionto removework_dirandwal_uriparameters in favor of directly passing the resolved WAL directory. [1] [2] [3]NeugDBto combine WAL ingestion and graph opening intoopenGraphAndIngestWals, and updated related method signatures to removework_dirparameters. [1] [2] [3] [4]Service and Transaction Logic
These changes make WAL handling more robust and less error-prone by removing unnecessary configuration indirection.