Skip to content

refactor: Remove wal_uri from config and remove dummy work_dir parameter#230

Merged
zhanglei1949 merged 1 commit into
alibaba:mainfrom
zhanglei1949:zl/ref-wal-ingest
Apr 15, 2026
Merged

refactor: Remove wal_uri from config and remove dummy work_dir parameter#230
zhanglei1949 merged 1 commit into
alibaba:mainfrom
zhanglei1949:zl/ref-wal-ingest

Conversation

@zhanglei1949
Copy link
Copy Markdown
Member

@zhanglei1949 zhanglei1949 commented Apr 15, 2026

This pull request simplifies and standardizes how the Write-Ahead Log (WAL) directory is handled throughout the codebase. The main changes remove the wal_uri configuration from NeugDBConfig, eliminate the parse_wal_uri function, and update related interfaces and method signatures to use a direct wal_dir approach. This reduces configuration complexity and potential sources of error related to WAL path resolution.

Configuration Simplification

  • Removed the wal_uri field and related logic from NeugDBConfig, so WAL directory handling is now standardized and no longer configurable via template strings. [1] [2] [3]
  • Deleted the parse_wal_uri function and all calls to it, removing support for {GRAPH_DATA_DIR} template expansion. [1] [2]

Interface and Method Updates

  • Updated constructors and methods in SessionLocalContext, SessionPool, and UpdateTransaction to remove work_dir and wal_uri parameters in favor of directly passing the resolved WAL directory. [1] [2] [3]
  • Refactored NeugDB to combine WAL ingestion and graph opening into openGraphAndIngestWals, and updated related method signatures to remove work_dir parameters. [1] [2] [3] [4]

Service and Transaction Logic

  • Updated service initialization and WAL ingestion logic to use the new direct WAL directory approach, ensuring consistency across the codebase. [1] [2]

These changes make WAL handling more robust and less error-prone by removing unnecessary configuration indirection.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@zhanglei1949 zhanglei1949 requested a review from liulx20 April 15, 2026 07:01
@zhanglei1949 zhanglei1949 merged commit 0681380 into alibaba:main Apr 15, 2026
17 checks passed
@lnfjpt lnfjpt mentioned this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants