refactor: Refactor the dependency between CMake targets#310
Merged
Conversation
liulx20
approved these changes
May 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #308
This pull request updates the build dependencies across multiple CMake configuration files. The main change is replacing the dependency on
neug_plan_protowith a dependency onneug_protofor various internal libraries. This ensures that all affected components now depend on the correct proto target, likely due to a consolidation or renaming of proto dependencies.Build system dependency updates:
add_dependencies(... neug_plan_proto)withadd_dependencies(... neug_proto)in the following libraries and their respectiveCMakeLists.txtfiles:neug_common(src/common/CMakeLists.txt)neug_binder,neug_binder_bind,neug_binder_bind_copy,neug_binder_bind_ddl,neug_binder_bind_read,neug_binder_bind_expression,neug_binder_ddl,neug_binder_expression,neug_binder_query,neug_binder_rewriter,neug_binder_visitor(various subdirectories ofsrc/compiler/binder/) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]neug_catalog,neug_catalog_entry(src/compiler/catalog/,src/compiler/catalog/catalog_entry/) [1] [2]compiler_common,neug_common_arrow,neug_common_copier_config,neug_common_data_chunk,neug_common_enums,neug_common_task_system(various subdirectories ofsrc/compiler/common/) [1] [2] [3] [4] [5] [6]This change helps maintain consistency and ensures all relevant targets are built against the updated proto dependency.