Skip to content

fix: adjust precedence for string/list predicates with NOT#322

Merged
Spockkk0225 merged 3 commits into
mainfrom
fix/precedence-not-ops-311-321
May 7, 2026
Merged

fix: adjust precedence for string/list predicates with NOT#322
Spockkk0225 merged 3 commits into
mainfrom
fix/precedence-not-ops-311-321

Conversation

@Spockkk0225
Copy link
Copy Markdown
Collaborator

@Spockkk0225 Spockkk0225 commented May 7, 2026

Summary

  • assign STARTS WITH / ENDS WITH / CONTAINS / IN scalar expressions a higher precedence bucket so NOT combinations parse and evaluate correctly
  • add python binding regression tests for NOT ('a' STARTS WITH 'a') and NOT (n.p0 IN [...])
  • keep scope limited to precedence logic and query regression coverage

Test plan

  • Run full test suite
  • Code review of precedence mapping and test assertions

Fixes #311
Fixes #321

Made with Cursor

Ensure STARTS WITH/ENDS WITH/CONTAINS/IN expressions use higher precedence consistent with POWER and add regression tests covering NOT combinations to prevent incorrect query evaluation.

Co-authored-by: Cursor <cursoragent@cursor.com>

Committed-by: Yu Shao from Dev container
Committed-by: Yu Shao from Dev container
Committed-by: Yu Shao from Dev container
@Spockkk0225 Spockkk0225 requested a review from shirly121 May 7, 2026 07:14
@Spockkk0225 Spockkk0225 merged commit ef48e56 into main May 7, 2026
19 checks passed
@lnfjpt lnfjpt mentioned this pull request May 26, 2026
@longbinlai longbinlai deleted the fix/precedence-not-ops-311-321 branch June 3, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NOT (x IN [...]) can return wrong results in embedded mode [BUG] NOT (STARTS WITH ...) OR ... IN [...] can segfault in embedded mode

2 participants