refactor: wrap VertexTable::indexer_ and v_ts_ as std::shared_ptr#391
Merged
zhanglei1949 merged 2 commits intoMay 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares VertexTable for upcoming copy-on-write snapshotting by wrapping the internal indexer_ and v_ts_ members in std::shared_ptr, enabling future use_count()-based “is shared?” checks while keeping the external API (reference-returning accessors) unchanged.
Changes:
- Refactor
VertexTable::indexer_andVertexTable::v_ts_tostd::shared_ptrand update member access from.to->. - Update construction/move/swap paths to manage the new pointer-wrapped members.
- Adjust
VertexSetcreation and timestamp/indexer accessors to dereference internally, preserving existing public signatures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
include/neug/storages/graph/vertex_table.h |
Wraps indexer_/v_ts_ in shared_ptr, updates constructor/move/Swap and inline helpers to dereference internally. |
src/storages/graph/vertex_table.cc |
Updates runtime operations (Open, Dump, Close, CRUD, capacity mgmt) to use pointer access; modifies Drop() cleanup logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liulx20
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #390