refactor: consolidate Schema vertex/edge label check API#393
Merged
zhanglei1949 merged 4 commits intoMay 22, 2026
Merged
Conversation
Unify the naming convention of label existence and validity checks on Schema (and the schema-check helpers it surfaces through PropertyGraph). The pre-existing API mixed three styles (`has_*`, `contains_*`, `*_valid`, `exist`) and had several overlapping or misleading methods. Renames (snake_case `is_*` family): - contains_vertex_label / vertex_label_valid -> is_vertex_label_valid - contains_edge_label / edge_label_valid -> is_edge_label_valid - exist(...) -> is_edge_triplet_valid(...) - has_edge_label(...) -> has_edge_triplet(...) - IsVertexLabelSoftDeleted -> is_vertex_label_soft_deleted - IsEdgeLabelSoftDeleted -> is_edge_label_soft_deleted - IsVertexPropertySoftDeleted -> is_vertex_property_soft_deleted - IsEdgePropertySoftDeleted -> is_edge_property_soft_deleted Merged (semantic-preserving consolidation): - Schema::edge_triplet_valid (weak, tomb-bit-only check) folded into Schema::is_edge_triplet_valid, which now inlines the tomb check together with the e_schemas_ presence check. This also fixes the prior divergence between PropertyGraph::edge_triplet_check's string and label_t overloads. Removed (dead code, no callers): - PropertyGraph::edge_triplet_exist
zhanglei1949
force-pushed
the
zl/schema-label-check-consolidation
branch
from
786309c to
fbe219b
Compare
liulx20
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #392
Summary
is_*familySchema::edge_triplet_valid(tomb-bit-only) into the strongis_edge_triplet_valid(which also requirese_schemas_presence); this fixes the prior divergence between the twoPropertyGraph::edge_triplet_checkoverloads as a side effectPropertyGraph::edge_triplet_exist(no callers anywhere)See #392 for the full rename table and the rationale.
The
is_*_soft_deletedfamily is renamed (snake_case) but kept in this PR —UpdateTransactionstill calls it onmain. Removing the family is a separate cleanup tied to the COW Update Transaction work.