chore(third_party): add licenses for jieba, lucene++, boost and support mirror download#127
Merged
lxy-9602 merged 8 commits intoalibaba:mainfrom Feb 10, 2026
Merged
Conversation
zjw1111
reviewed
Feb 10, 2026
lxy-9602
force-pushed
the
boost-jieba-rm-recursive-git
branch
from
92cf11a to
1c3fc16
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the third-party dependency toolchain to support Lucene++ full-text search prerequisites by adding version/checksum metadata and adjusting download/build wiring, while also adding license/NOTICE attributions for newly introduced dependencies.
Changes:
- Added limonp + cppjieba version/checksum metadata and switched cppjieba from git-based fetching to URL+SHA256 fetching.
- Switched Boost to use a vendored tarball (Git LFS) with SHA256 verification and updated Lucene++ build to depend on/link zlib.
- Added third-party attributions for Boost, LucenePlusPlus, and cppjieba in NOTICE/LICENSE.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/versions.txt | Adds version/checksum/pkg metadata for limonp/jieba/boost and extends DEPENDENCIES list |
| third_party/boost/boost_1_66_0.tar.gz | Adds Boost source tarball via Git LFS pointer |
| cmake_modules/ThirdpartyToolchain.cmake | Adds mirror/env URL handling for limonp/jieba, updates Lucene++ zlib wiring, switches Boost/Jieba to URL tarball fetches |
| NOTICE | Adds third-party attribution entries (Boost/LucenePlusPlus/cppjieba) |
| LICENSE | Adds license text/sections for Boost and cppjieba, and attribution for LucenePlusPlus |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #69