fix: fix some disabled ut in FileStoreCommitImplTest#148
Merged
zjw1111 merged 7 commits intoalibaba:mainfrom Feb 26, 2026
Merged
fix: fix some disabled ut in FileStoreCommitImplTest#148zjw1111 merged 7 commits intoalibaba:mainfrom
zjw1111 merged 7 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes disabled unit tests in FileStoreCommitImplTest by refactoring the mock filesystem setup approach and reorganizing includes to follow project conventions.
Changes:
- Enabled three previously disabled tests related to commit conflict handling and atomic write timeout scenarios
- Refactored mock filesystem setup to use
WithFileSystem()instead ofFILE_SYSTEMoption, allowing direct access to the mock object - Reorganized include statements in multiple files to follow the project convention (system headers first, then project headers, both alphabetically sorted)
- Added
git lfs pullinstructions to documentation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/paimon/core/operation/file_store_commit_impl_test.cpp | Enabled three disabled tests, refactored mock filesystem setup to use direct injection, changed lambda captures from reference to pointer, added wildcard EXPECT_CALL for ListDir |
| src/paimon/core/utils/tag_manager.cpp | Reordered includes to follow convention (system headers before project headers) |
| src/paimon/core/catalog/renaming_snapshot_commit.h | Reordered includes to follow convention |
| src/paimon/core/casting/string_to_timestamp_cast_executor.cpp | Reordered includes to follow convention |
| docs/source/building.rst | Added git lfs pull instruction to clone steps |
| README.md | Added new section with git lfs pull instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lszskye
pushed a commit
to lszskye/paimon-cpp
that referenced
this pull request
Feb 28, 2026
lxy-9602
pushed a commit
that referenced
this pull request
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
TEST_F(FileStoreCommitImplTest, TestCommitWithConflictSnapshotAndRetryTenTimes)
TEST_F(FileStoreCommitImplTest, TestCommitWithConflictSnapshotAndRetryOnce)
TEST_F(FileStoreCommitImplTest, TestCommitWithAtomicWriteSnapshotTimeoutAndActuallySucceed)
API and Format
Documentation