fix(core): avoid error when manifest entry has value_stats_cols#150
Merged
lxy-9602 merged 4 commits intoalibaba:mainfrom Feb 27, 2026
Merged
fix(core): avoid error when manifest entry has value_stats_cols#150lxy-9602 merged 4 commits intoalibaba:mainfrom
lxy-9602 merged 4 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents KeyValueFileStoreScan from throwing Status::NotImplemented when manifest entries contain value_stats_cols but value filtering is not actually enabled, by short-circuiting whole-bucket filtering paths when the value filter is disabled.
Changes:
- Add
IsValueFilterEnabled()checks to bypassFilterByValueFilter(...)inFilterWholeBucketPerFile. - Add
IsValueFilterEnabled()checks to bypassFilterByValueFilter(...)inFilterWholeBucketAllFiles.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SGZW
force-pushed
the
zhangwei/fix_read
branch
from
2d889b2 to
4764a4e
Compare
lxy-9602
reviewed
Feb 26, 2026
SGZW
force-pushed
the
zhangwei/fix_read
branch
from
9cbdc76 to
ebd3a3e
Compare
lxy-9602
reviewed
Feb 27, 2026
SGZW
force-pushed
the
zhangwei/fix_read
branch
from
ebd3a3e to
66dcf84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a manifest entry contains value_stats_cols but has not enabled the value filter, reading the PK table will throw a NotImplemented error. I've identified that the value filter functionality is actually not implemented in the code; I've temporarily bypassed this issue with a special check and will implement the value_stats_cols filter later.
Tests
API and Format
Documentation