fix: mem leak in write when I/O exception occurs#165
Merged
Conversation
lszskye
approved these changes
Mar 4, 2026
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/paimon-cpp
that referenced
this pull request
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a memory issue in
MergeTreeWriterandMergeTreeCompactRewriterthat occurs when an I/O exception happens during write or compaction.Previously, upon I/O error, we called
writer->Close()as part of cleanup. However,Close()may trigger aFlush()which attempts to write out buffered data. Due to shallow copies in the format layer (e.g., arrow array -> orc batch), some of this data may have already been released or invalidated by the time flush runs — leading to use-after-free.