fix(compaction): make sure that only one task is running at a time, refactor compaction manager creation and add test #201
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves compaction task lifecycle handling to prevent overlapping compaction executions by ensuring outstanding compaction work is joined before starting a new task or closing writers.
Changes:
- Make
CancelCompaction()synchronously wait for the active compaction future to finish, removing the “detached futures” list. - Update writer close-path comments to reflect “cancel + wait” behavior.
- Remove tracking/waiting of previously “cancelled” futures in the compaction future manager.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/paimon/core/mergetree/merge_tree_writer.h | Updates close-path comments to describe cancel + wait behavior. |
| src/paimon/core/compact/compact_future_manager.h | Changes cancellation semantics to move+wait the active future; removes cancelled futures tracking. |
| src/paimon/core/append/append_only_writer.cpp | Updates close-path comments to describe cancel + wait behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucasfang
force-pushed
the
compaction_dev
branch
from
8465a81 to
02a3276
Compare
lucasfang
changed the title
lxy-9602
reviewed
Mar 30, 2026
lxy-9602
reviewed
Mar 30, 2026
lxy-9602
reviewed
Mar 30, 2026
lxy-9602
reviewed
Mar 30, 2026
lxy-9602
reviewed
Mar 30, 2026
lucasfang
force-pushed
the
compaction_dev
branch
from
58bd188 to
18a4ca0
Compare
lxy-9602
reviewed
Mar 30, 2026
lxy-9602
reviewed
Mar 30, 2026
lucasfang
force-pushed
the
compaction_dev
branch
from
30fa282 to
07b29b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests
API and Format
Add options for pk compaction.
lookup-wait
Generative AI tooling
Generated-by: GitHub Copilot (GPT-5.3-Codex)