Skip to content

fix: Fix missing StatusCode switch cases and correct Literal hash qualifier#248

Merged
lxy-9602 merged 2 commits into
alibaba:mainfrom
Smith-Cruise:improve-something
Apr 25, 2026
Merged

fix: Fix missing StatusCode switch cases and correct Literal hash qualifier#248
lxy-9602 merged 2 commits into
alibaba:mainfrom
Smith-Cruise:improve-something

Conversation

@Smith-Cruise
Copy link
Copy Markdown
Contributor

@Smith-Cruise Smith-Cruise commented Apr 24, 2026

Purpose

  • Add missing StatusCode::NotExist and StatusCode::Exist cases in Status::CodeAsString(StatusCode), so these error codes produce proper string representations instead of falling through to "Unknown".
  • Fix std::hash<paimon::Literal> specialization to use ::paimon::Literal (global namespace qualifier) instead of paimon::Literal, avoiding potential ambiguity in nested namespace contexts.

Linked issue: close #xxx

Tests

API and Format

Documentation

Generative AI tooling

Signed-off-by: Smith Cruise <chendingchao1@126.com>
Copy link
Copy Markdown
Collaborator

@lxy-9602 lxy-9602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602 lxy-9602 merged commit 3c94e82 into alibaba:main Apr 25, 2026
9 checks passed
@lxy-9602 lxy-9602 changed the title Fix missing StatusCode switch cases and correct Literal hash qualifier fix: Fix missing StatusCode switch cases and correct Literal hash qualifier Apr 25, 2026
@Smith-Cruise Smith-Cruise deleted the improve-something branch April 25, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants