feat: support file type classify#254
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a FileType abstraction and utility methods to classify Paimon file paths into meta/data/index categories, with unit tests validating expected behavior across common path patterns (including branch and temp-wrapped names).
Changes:
- Introduces
FileTypeenum andFileTypeUtilsAPI (IsIndex,Classify,ToString). - Implements path-based classification logic including temp-file name unwrapping.
- Adds comprehensive GTest coverage for classification cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/paimon/common/utils/file_type.h | Declares FileType and FileTypeUtils public API. |
| src/paimon/common/utils/file_type.cpp | Implements classification, string conversion, and temp-name unwrapping. |
| src/paimon/common/utils/file_type_test.cpp | Adds unit tests covering meta/data/index classification and edge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a FileType abstraction and utility methods to classify Paimon file paths into meta/data/index categories.
Tests
FileTypeTest
TestIsIndex
TestMetaPrefix
TestIndexTypes
TestMetaSpecialNames
TestDefaultData
TestChangelogInAncestorPathNotMisclassified
TestBranchPaths
TestTempWrappedName
TestInvalidTempWrapperFallsBackToOriginalName
API and Format
Documentation
Generative AI tooling