feat(parquet): add metrics for parquet reader observability#258
Merged
Conversation
Add row groups, rows, batch count, and latency metrics to ParquetFileBatchReader, matching the observability level of the ORC reader. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move parquet read metric constants into the existing ParquetMetrics class in parquet_format_defs.h, rather than defining a duplicate class in a new header. Fixes build error introduced in d5a8bfa. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
lxy-9602
reviewed
Apr 29, 2026
lucasfang
reviewed
Apr 29, 2026
|
|
…unter Rename row_groups/batch.count to dot-hyphen convention (dot for hierarchy, hyphen for words within a level). Remove READ_NEXT_BATCH_LATENCY_MS counter: summing per-batch latency across prefetch sub-readers scales with parallelism and does not reflect end-to-end latency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
duanyyyyyyy
force-pushed
the
duanyan/parquet_metrics
branch
from
d18e8a0 to
6c780fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add row groups, rows, batch count, and latency metrics to ParquetFileBatchReader, matching the observability level of the ORC reader.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation
Generative AI tooling
Opus 4.6