test: add ut for prefetch file batch reader#277
Merged
Conversation
lucasfang
changed the title
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds additional unit tests to improve coverage for PrefetchFileBatchReaderImpl, including adaptive-prefetch behavior and failure/edge-path handling.
Changes:
- Introduce controlled mock reader/builder to deterministically control read ranges and injected failures.
- Add UTs covering adaptive-prefetch disabling, pushdown failure propagation, cache init failure, and edge conditions in read loop/batch reads.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
add ut for prefetch file batch reader for test coverage
Tests
PrefetchFileBatchReaderImplTest
RefreshReadRangesDisablePrefetchByAdaptiveStrategy
SetReadRangesReturnErrorWhenPushDownFailed
NeedInitCacheNeverMode
WorkloopSetReadStatusWhenCacheInitFailed
DoReadBatchReturnOkWhenShutdown
DoReadBatchReturnOkWhenNoCurrentReadRange
API and Format
Documentation
Generative AI tooling