feat: support BlobDescriptor with version 2#290
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for BlobDescriptor serialization/deserialization version 2 (with a magic header) and extends integration/unit tests plus fixture tables to validate multi-blob reading and Java compatibility.
Changes:
- Introduce BlobDescriptor v2 format (adds magic header) and a helper
IsBlobDescriptor. - Update BlobDescriptor unit tests for v1/v2 Java compatibility and new identifier checks.
- Add parquet/orc fixture tables + a new integration test for reading tables with multiple blob columns.
Reviewed changes
Copilot reviewed 14 out of 34 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
src/paimon/common/data/blob_descriptor.h |
Documents v2 layout, bumps current version to 2, adds APIs (Create(version,...), IsBlobDescriptor) and MAGIC. |
src/paimon/common/data/blob_descriptor.cpp |
Implements v2 serialization (writes magic), v1/v2 deserialization, and IsBlobDescriptor. |
src/paimon/common/data/blob_descriptor_test.cpp |
Splits Java compatibility tests for v1/v2 and adds IsBlobDescriptor test coverage. |
test/inte/blob_table_inte_test.cpp |
Adds integration test to read multi-blob fields and validate null handling + row range scanning. |
test/test_data/**/append_table_with_multi_blob.db/** |
Adds parquet/orc fixture dataset (schema/snapshot/readme) used by the integration test. |
Comments suppressed due to low confidence (1)
src/paimon/common/data/blob_descriptor.cpp:1
- The new version check only enforces an upper bound. This will accept
version <= 0and then parse using the v1 branch (no magic), which is very likely unintended and can cause mis-parsing of arbitrary bytes. Add a lower-bound validation (e.g., require version to be 1 or 2) and returnStatus::Invalidfor unsupported/negative versions.
/*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lxy-9602
reviewed
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
support BlobDescriptor with version 2
Linked issue: #283
Tests
BlobTableInteTest