fix: fix undefined behavior in bitwise left-shift operations across codebase#308
Merged
Conversation
zjw1111
reviewed
May 27, 2026
Collaborator
zjw1111
left a comment
zjw1111
left a comment
There was a problem hiding this comment.
I found one correctness issue in the varint decoder overflow handling.
lszskye
approved these changes
May 28, 2026
lxy-9602
added a commit
to lxy-9602/paimon-cpp
that referenced
this pull request
May 28, 2026
lxy-9602
added a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
No Linked issue.
Fix all signed left-shift undefined behavior (UB) across the codebase - signed left-shift that overflows or operates on negative values is UB per the C++ standard.
Tests
API and Format
Documentation
Generative AI tooling
Generated-by: Claude-4.6-Opus