create time should in seconds instead of nano seconds#2955
Merged
Conversation
Signed-off-by: frankyang <yyb196@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2955 +/- ##
==========================================
- Coverage 68.19% 68.14% -0.05%
==========================================
Files 291 291
Lines 18351 18351
==========================================
- Hits 12514 12506 -8
- Misses 4382 4384 +2
- Partials 1455 1461 +6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: frankyang yyb196@gmail.com
Ⅰ. Describe what this PR did
when doing container list create time of every container should in seconds, or users who use docker as client to list containers will get the wrong create time. according to https://docs.docker.com/engine/api/v1.24/
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
test cases has been modified
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews