fix node e2e test#2991
Merged
Merged
Conversation
Collaborator
|
Thanks for your contribution. 🍻 @zhuangqh |
Codecov Report
@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
+ Coverage 66.74% 67.99% +1.25%
==========================================
Files 291 291
Lines 18655 18660 +5
==========================================
+ Hits 12451 12688 +237
+ Misses 4719 4488 -231
+ Partials 1485 1484 -1
|
Contributor
|
ping @zhuangqh , I think we missing a patch here for nil panic issue. could you update the pr in time? Thanks |
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhuangqh zhuangqhc@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews