feat(config): support engine type in eval config#10
Merged
Conversation
Collaborator
|
The eval.yaml under examples/ and e2e/ may also need rename from name to type |
lbfsc
requested changes
May 15, 2026
Collaborator
lbfsc
left a comment
lbfsc
left a comment
There was a problem hiding this comment.
The changes to the installation method and the streamlined documentation are excellent. However, too many new design elements were added, which does not align with expectations. Currently, the Name field better meets the design requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests