Skip to content

Dev #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FateRiddle merged 17 commits into from
Nov 22, 2019
Merged

Dev #19

FateRiddle merged 17 commits into from
Nov 22, 2019

Conversation

@FateRiddle
Copy link
Contributor

@FateRiddle FateRiddle commented Nov 21, 2019

修复部分bug

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ tw93
✅ FateRiddle
❌ huchisupot
You have signed the CLA already but the status is still pending? Let us recheck it.

tw93
tw93 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@tw93 tw93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FateRiddle FateRiddle merged commit 2dc2903 into master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tw93 tw93 tw93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@FateRiddle @CLAassistant @antonmedv @tw93 @shenyuhan520 @huchisupot