Merged
Conversation
The android-actions/setup-android@v4 action fails on ARM64 Linux because the emulator SDK package is not published for that platform. Switch to ubuntu-24.04 (x86_64) where sdkmanager fully supports the emulator package. NDK cross-compilation for arm64-v8a works on any host architecture.
x86_64 Linux emulator refuses ARM64 system images (QEMU2 requires host arch match). ARM64 Linux has no emulator SDK package. macOS 14 (Apple Silicon) runs ARM64 images natively via Hypervisor.framework. Changes: - runs-on: macos-14 - brew install instead of apt-get - Remove android-actions/setup-android (SDK pre-installed on macOS) - BSD find (-perm +111) and sysctl for macOS compatibility
Replace android-actions/setup-android@v4 with manual cmdline-tools installation. cmdline-tools is Java-based and works on any arch. Emulator install uses 3-tier fallback: sdkmanager → canary channel → direct download from SDK repository XML.
ARM64 Linux has no emulator package in Google SDK. Use x86_64 Linux with KVM hardware acceleration for fast emulator testing. Changes: - runs-on: ubuntu-24.04 (x86_64) - ABI: x86_64 (emulator + system image + NDK cross-compile) - android-actions/setup-android@v4 (works on x86_64) - Enable KVM for emulator acceleration - All arm64-v8a refs updated to x86_64
…ility /tmp is read-only on Android x86_64 emulator. Use relative paths (./zvec_test_*) which resolve to the per-test working directory set up by the CI test runner. - collection_test.cc: replace /tmp/absolute/path with relative paths - c_api_test.c: replace all 15 /tmp/zvec_test_* with ./zvec_test_*
feihongxu0824
requested review from
Cuiyus,
egolearner,
iaojnh and
zhourrr
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
iaojnh
pushed a commit
to iaojnh/zvec
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.