Skip to content

minor: remove unused validation in c api #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhourrr merged 1 commit into from
May 8, 2026
Merged

minor: remove unused validation in c api #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions src/binding/c/c_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4307,37 +4307,6 @@ size_t zvec_doc_memory_usage(const zvec_doc_t *doc) {
return doc_ptr->memory_usage();)
}

zvec_error_code_t zvec_doc_validate_and_sanitize(zvec_doc_t *doc,
const zvec_collection_schema_t *schema,
bool is_update, char **error_msg) {
if (!doc || !schema) {
set_last_error("Document or schema pointer is null");
return ZVEC_ERROR_INVALID_ARGUMENT;
}

ZVEC_TRY_RETURN_ERROR(
"Failed to validate document",
std::shared_ptr<zvec::CollectionSchema> schema_ptr = nullptr;
auto status =
convert_zvec_collection_schema_to_internal(schema, schema_ptr);
if (!status.ok()) {
if (error_msg) {
*error_msg = copy_string(status.message());
}
return status_to_error_code(status);
}

auto doc_ptr = reinterpret_cast<zvec::Doc *>(doc);
status = doc_ptr->validate_and_sanitize(schema_ptr, is_update); if (!status.ok()) {
if (error_msg) {
*error_msg = copy_string(status.message());
}
return status_to_error_code(status);
}

if (error_msg) { *error_msg = nullptr; }
return ZVEC_OK;)
}

zvec_error_code_t zvec_doc_to_detail_string(const zvec_doc_t *doc, char **detail_str) {
if (!doc || !detail_str) {
Expand Down
12 changes: 0 additions & 12 deletions src/include/zvec/c_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3035,18 +3035,6 @@ ZVEC_EXPORT void ZVEC_CALL zvec_doc_merge(zvec_doc_t *doc,
*/
ZVEC_EXPORT size_t ZVEC_CALL zvec_doc_memory_usage(const zvec_doc_t *doc);

/**
* @brief Validate document against Schema
*
* @param doc Document object pointer
* @param schema Schema object pointer
* @param is_update Whether it's an update operation
* @param[out] error_msg Error message (needs manual release)
* @return zvec_error_code_t Error code
*/
ZVEC_EXPORT zvec_error_code_t ZVEC_CALL zvec_doc_validate_and_sanitize(
zvec_doc_t *doc, const zvec_collection_schema_t *schema, bool is_update,
char **error_msg);

/**
* @brief Get detailed string representation of document
Expand Down
10 changes: 1 addition & 9 deletions tests/c/c_api_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4783,14 +4783,6 @@ void test_doc_advanced_functions(void) {
zvec_doc_add_field_by_value(val_doc, "test_field", ZVEC_DATA_TYPE_INT32,
&(int32_t){42}, sizeof(int32_t));

char *error_msg = NULL;
zvec_error_code_t err =
zvec_doc_validate_and_sanitize(val_doc, schema, false, &error_msg);
TEST_ASSERT(err == ZVEC_OK);
if (error_msg) {
zvec_free(error_msg);
}

zvec_doc_destroy(val_doc);
zvec_collection_schema_destroy(schema);
zvec_doc_destroy(doc);
Expand All @@ -4804,7 +4796,7 @@ void test_doc_advanced_functions(void) {
"hello", 5);

char *detail_str = NULL;
err = zvec_doc_to_detail_string(detail_doc, &detail_str);
zvec_error_code_t err = zvec_doc_to_detail_string(detail_doc, &detail_str);
TEST_ASSERT(err == ZVEC_OK);
TEST_ASSERT(detail_str != NULL);
// printf(" Document detail: %s\n", detail_str);
Expand Down
Loading