Skip to content

fix platform api build oom #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alongubkin merged 1 commit into from
Jun 2, 2026
Merged

fix platform api build oom #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client-sdks/platform/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"sideEffects": false,
"scripts": {
"lint": "eslint --cache --max-warnings=0 src",
"build": "tsc",
"build": "node --max-old-space-size=8192 node_modules/typescript/bin/tsc",
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Using node_modules/typescript/bin/tsc reaches directly into the package's internal directory tree. The conventional and more portable path is ./node_modules/.bin/tsc — this is the symlink every package manager (npm, pnpm, yarn) guarantees to create for declared devDependencies, and it doesn't depend on TypeScript keeping bin/tsc at that exact internal path.

Suggested change
"build": "node --max-old-space-size=8192 node_modules/typescript/bin/tsc",
"build": "node --max-old-space-size=8192 ./node_modules/.bin/tsc",
Prompt To Fix With AI 
This is a comment left during a code review.
Path: client-sdks/platform/typescript/package.json
Line: 55

Comment:
Using `node_modules/typescript/bin/tsc` reaches directly into the package's internal directory tree. The conventional and more portable path is `./node_modules/.bin/tsc` — this is the symlink every package manager (npm, pnpm, yarn) guarantees to create for declared `devDependencies`, and it doesn't depend on TypeScript keeping `bin/tsc` at that exact internal path.

```suggestion
    "build": "node --max-old-space-size=8192 ./node_modules/.bin/tsc",
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"prepublishOnly": "npm run build"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"build": "turbo build",
"build:images": "echo 'Use GitHub Actions workflows (.github/workflows/images*.yml) for canonical image builds'",
"generate": "turbo run generate",
"generate:platform-api": "speakeasy generate sdk --lang typescript --schema ./client-sdks/platform/openapi.json --out client-sdks/platform/typescript && NODE_OPTIONS=--max-old-space-size=8192 pnpm -C ./client-sdks/platform/typescript build",
"generate:platform-api": "speakeasy generate sdk --lang typescript --schema ./client-sdks/platform/openapi.json --out client-sdks/platform/typescript && pnpm -C ./client-sdks/platform/typescript build",
"generate:manager-api": "speakeasy generate sdk --lang typescript --schema ./client-sdks/manager/openapi.json --out client-sdks/manager/typescript && pnpm -C ./client-sdks/manager/typescript build",
"generate:manager-openapi": "cargo run --bin alien-manager-schema-exporter --features openapi -p alien-manager -- --output crates/alien-manager/openapi.json && cp crates/alien-manager/openapi.json client-sdks/manager/openapi.json",
"generate:manager-rust-sdk": "pnpm run generate:manager-openapi && openapi-down-convert -i crates/alien-manager/openapi.json -o client-sdks/manager/rust/openapi-3.0.json && cd client-sdks/manager/rust && node ../scripts/fix-openapi.mjs",
Expand Down
Loading