Update maintenance plugin to support changes to Maint mode API #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI that allow multiple sites to be placed in / out of maintenance mode
AdamJHall
requested review from
TheOrangePuff,
aaronmedina-dev,
crispy101,
hubertott and
porhkz
|
Looks fine @AdamJHall Just checking we don't need more handling around the presence/contents of the maintenance file? I assume if this code is running we're confident the maintenance file exists? |
tvhees
approved these changes
May 26, 2025
|
Also this repo really needs some time put in to it to get the builds working again :( |
Contributor
Author
We do check for it's existence, for the content side we're relying on the fact that it's created via an API and code we control and validated on that end. We could add some more basic validation in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR updates the maintenance mode plugin to check the host header, and the IP allow list against the sites and allow list in maintenance file.
REF: aligent/cdk-constructs#1487
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback