Feature/181 support additional customer endpoints #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellboy1975
reviewed
Feb 26, 2023
|
|
||
| public function getAll(array $filters = [], int $page = 1, int $limit = 250): PaginatedResponse | ||
| { | ||
| throw new \UnexpectedValueException("Unable to get all Customer Settings Per Channel"); |
There was a problem hiding this comment.
@jswift just checking this function should always throw an exception?
There was a problem hiding this comment.
Yeh, it's required by the interface but for some reason BC haven't implemented an endpoint like they have for all the others.
hellboy1975
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some of the stranger endpoints on Customer. It's quite different to other endpoints, but this adds access to
Fixes #181