Skip to content

persist-credentials: false breaks git fetch origin in node-pr.yml build and test jobs #114

@aaronmedina-dev

Description

@aaronmedina-dev

Summary

PR #103 (DO-1802) added persist-credentials: false to the checkout steps in node-pr.yml as a zizmor security hardening fix. This breaks the subsequent git fetch origin step in both the build and test jobs, since the GitHub token is stripped from the git config after checkout.

Error

fatal: could not read Username for 'https://github.com': No such device or address
##[error]Process completed with exit code 128.

Affected Jobs

  • build job (line ~209-211): persist-credentials: false on checkout, followed by git fetch origin
  • test job (line ~314-315): same pattern

Reproduction

Any repo calling node-pr.yml that triggers the build or test jobs will fail at the Fetch Origin step. Example: https://github.com/aligent/vulcan-pwa/actions/runs/23725201231/job/69107458601?pr=2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions