Skip to content

feat GSM-29: add shopify theme pr checks#129

Merged
TheOrangePuff merged 6 commits intomainfrom
feature/GSM-29-shopify-pr-workflow
Apr 17, 2026
Merged

feat GSM-29: add shopify theme pr checks#129
TheOrangePuff merged 6 commits intomainfrom
feature/GSM-29-shopify-pr-workflow

Conversation

@TheOrangePuff
Copy link
Copy Markdown
Member

Description of the proposed changes

  • Adds two workflows for Shopify themes
  • Includes a Shopify theme linter with annotations and automatic deployment of a preview theme
  • There is also a cleanup workflow
  • Example of what this should be doing: https://github.com/aligent/gsm-shopify-theme/pull/2
  • This is slightly different to that implementation (as need to make it a shared workflow) but the logic should be the same

Notes to reviewers

ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Includes a Shopify theme linter with annotations and automatically
deploy a preview theme
Comment thread .github/workflows/shopify-theme-pr.yml Fixed
Comment thread .github/workflows/shopify-theme-pr.yml Dismissed
Comment thread .github/workflows/shopify-theme-preview-cleanup.yml Dismissed
@TheOrangePuff TheOrangePuff marked this pull request as ready for review April 14, 2026 05:16
@TheOrangePuff TheOrangePuff requested a review from a team as a code owner April 14, 2026 05:16
AdamJHall
AdamJHall previously approved these changes Apr 14, 2026
Copy link
Copy Markdown
Contributor

@AdamJHall AdamJHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question about .nvmrc

Comment thread .github/workflows/shopify-theme-pr.yml
@TheOrangePuff TheOrangePuff merged commit 8eec947 into main Apr 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants