fix: ExtractRouteParams<string> rejecting array query values#8
Open
antoinekm wants to merge 1 commit intoalii:masterfrom
Open
fix: ExtractRouteParams<string> rejecting array query values#8antoinekm wants to merge 1 commit intoalii:masterfrom
antoinekm wants to merge 1 commit intoalii:masterfrom
Conversation
When T is a bare `string`, ExtractRouteParams resolved to `string`, causing Query<string> to collapse arrays out of the intersection. Changing the fallback to `never` keeps QueryValue (incl. arrays) reachable for every key. Also guard the route-param replacement branch against arrays so the internal `paramValueToString` call stays type-safe. Closes alii#7
Owner
|
Thank you! I'll look at this today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
pathcatwith a path that has no route params (e.g./stream),Query<string>does not accept array values despiteQueryValuesupporting them.Cause
ExtractRouteParams<string>resolves tostring(the catch-all branch), makingQuery<string>becomeRecord<string, ParamValue> & Record<string, QueryValue>. The intersection collapses toRecord<string, ParamValue>, eliminating arrays.Fix
ExtractRouteParams<string>fallback fromstringtoneversoQuery<string>becomesRecord<never, ParamValue> & Record<string, QueryValue>=Record<string, QueryValue>paramValueToStringtype-safeAll 23 existing tests pass unchanged.
Closes #7