Skip to content

license#53

Merged
alikon merged 4 commits intomainfrom
prepare-for-jed
Apr 11, 2026
Merged

license#53
alikon merged 4 commits intomainfrom
prepare-for-jed

Conversation

@alikon
Copy link
Copy Markdown
Owner

@alikon alikon commented Apr 11, 2026

Summary by Sourcery

Enhancements:

  • Add or update PHPDoc headers for various modules and plugins to standardize package, copyright, author, and license declarations across the codebase.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 11, 2026

Reviewer's Guide

Adds and standardizes PHP file headers and licensing/metadata docblocks across multiple Joomla modules and plugins, aligning package/subpackage names and copyright/license info while leaving runtime behavior unchanged.

File-Level Changes

Change Details Files
Introduce consistent Joomla-style docblock headers for module and plugin PHP entry files, including copyright and license metadata.
  • Add @Package and @subpackage tags matching each extension (Module.portfolio, Module.Jstats, System.magiclogin, Console.safemode, Content.swaggerui, System.safemode, Task.DelTrash).
  • Add or update copyright lines to use Alikon/Alikonweb or Joomla OSM with years and URLs as appropriate.
  • Add @license tags pointing to GPL v2/v3 and LICENSE(.txt) files, plus @author/@link where relevant.
src/modules/mod_github_portfolio/tmpl/default.php
src/modules/mod_github_portfolio/field/links.php
src/modules/mod_github_portfolio/field/version.php
src/modules/mod_github_portfolio/services/provider.php
src/modules/mod_github_portfolio/src/Dispatcher/Dispatcher.php
src/modules/mod_github_portfolio/src/Helper/GithubPortfolioHelper.php
src/modules/mod_jstats/field/links.php
src/modules/mod_jstats/field/version.php
src/modules/mod_jstats/services/provider.php
src/modules/mod_jstats/src/Dispatcher/Dispatcher.php
src/modules/mod_jstats/tmpl/default.php
src/plugins/system/magiclogin/field/links.php
src/plugins/system/magiclogin/field/version.php
src/plugins/console/safemode/field/links.php
src/plugins/console/safemode/field/version.php
src/plugins/content/swaggerui/field/links.php
src/plugins/content/swaggerui/field/version.php
src/plugins/system/safemode/field/links.php
src/plugins/system/safemode/field/version.php
src/plugins/task/deltrash/field/links.php
src/plugins/task/deltrash/field/version.php
src/plugins/task/deltrash/rules/conditionalcategory.php
Normalize the Joomla security check usage and package metadata for selected files.
  • Switch bare defined('_JEXEC') or die to namespaced \defined('_JEXEC') or die in files that previously used the global function.
  • Align @Package and @subpackage values in mod_jstats provider, dispatcher, and template to the Module.Jstats naming used elsewhere.
  • Update mod_jstats copyright owners/years to Alikon 2026 for consistency.
src/modules/mod_github_portfolio/tmpl/default.php
src/modules/mod_jstats/services/provider.php
src/modules/mod_jstats/src/Dispatcher/Dispatcher.php
src/modules/mod_jstats/tmpl/default.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues, and left some high level feedback:

  • In the magiclogin field headers (links.php and version.php), the @copyright line uses https://wwww.alikonweb.it (four ws); this should be corrected to the intended domain.
  • The magiclogin fields use GNU General Public License version 3 or later; see LICENSE while the rest of the codebase here generally uses version 2 or later; see LICENSE.txt; please double-check that the GPL version and LICENSE file reference are intentionally different and consistent with the rest of the extension and project licensing policy.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the magiclogin field headers (links.php and version.php), the @copyright line uses `https://wwww.alikonweb.it` (four `w`s); this should be corrected to the intended domain.
- The magiclogin fields use `GNU General Public License version 3 or later; see LICENSE` while the rest of the codebase here generally uses `version 2 or later; see LICENSE.txt`; please double-check that the GPL version and LICENSE file reference are intentionally different and consistent with the rest of the extension and project licensing policy.

## Individual Comments

### Comment 1
<location path="src/plugins/system/magiclogin/field/links.php" line_range="8" />
<code_context>
+ *
+ * @author     Alikon <alikon@alikonweb.it>
+ *
+ * @copyright  (C) 2025, Alikonweb <https://wwww.alikonweb.it>. All rights reserved.
+ * @license    GNU General Public License version 3 or later; see LICENSE
+ * @link       https://www.alikonweb.it
</code_context>
<issue_to_address>
**issue (typo):** The copyright URL has an extra `w` in the hostname.

The URL is written as `https://wwww.alikonweb.it` (four `w`s). Unless that hostname is intentional and valid, please change it to `https://www.alikonweb.it` to avoid a broken link in the copyright block.

```suggestion
 * @copyright  (C) 2025, Alikonweb <https://www.alikonweb.it>. All rights reserved.
```
</issue_to_address>

### Comment 2
<location path="src/plugins/system/magiclogin/field/version.php" line_range="8" />
<code_context>
+ *
+ * @author     Alikon <alikon@alikonweb.it>
+ *
+ * @copyright  (C) 2025, Alikonweb <https://wwww.alikonweb.it>. All rights reserved.
+ * @license    GNU General Public License version 3 or later; see LICENSE
+ * @link       https://www.alikonweb.it
</code_context>
<issue_to_address>
**issue (typo):** Same extra `w` in the copyright URL here as well.

This entry also uses `https://wwww.alikonweb.it`. Please update it (and the other magiclogin field) to the canonical host, e.g. `https://www.alikonweb.it`, to keep the headers consistent.

Suggested implementation:

```
 * @copyright  (C) 2025, Alikonweb <https://www.alikonweb.it>. All rights reserved.

```

There is likely at least one other `magiclogin` field file with the same header (the "other magiclogin field" mentioned in your comment). Apply the same `https://wwww.alikonweb.it``https://www.alikonweb.it` replacement to its `@copyright` (and any other header lines) to keep all plugin headers consistent.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread src/plugins/system/magiclogin/field/links.php Outdated
Comment thread src/plugins/system/magiclogin/field/version.php Outdated
@alikon alikon merged commit 7a3f517 into main Apr 11, 2026
39 checks passed
@alikon alikon deleted the prepare-for-jed branch April 11, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant