Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed
pnpminstead ofnpmfor installing dependencies and for running the build script. This is a more efficient package manager that can also respectpnpm-lock.yamlwhich is added in this PR for more deterministic builds.pnpm-lock.yamlfile and removes thepackage-lock.jsonfile, which corresponds tonpm. This enforces pnpm usage for future use.Additional Information
pnpmfromnpmis a conscious decision owing to its efficient installation process and better disk usage.pnpmfor any addition/removal/updation of dependencies.Testing
pnpm installto install the dependencies andpnpm run buildto execute the build script, as detailed in the updated README. They should run without errors and have the expected outcomes. If they haven't installedpnpm, they need to do that first by runningnpm install -g pnpm.