Skip to content

Bump FastJet to v3.4.1_1.052-alice1#4998

Merged
ktf merged 1 commit intomasterfrom
bump-fastjet
May 25, 2023
Merged

Bump FastJet to v3.4.1_1.052-alice1#4998
ktf merged 1 commit intomasterfrom
bump-fastjet

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented May 19, 2023

No description provided.

@ktf ktf requested a review from a team as a code owner May 19, 2023 16:44
@hahassan7
Copy link
Copy Markdown

Hi @ktf ,

Thanks for updating fastjet. But shouldn't we also bump it in the fastjet.sh script ??

@ktf
Copy link
Copy Markdown
Member Author

ktf commented May 21, 2023

That's for aliphysics.

@hahassan7
Copy link
Copy Markdown

I see. Then it's good. Thanks !

@hahassan7
Copy link
Copy Markdown

Hi @ktf , Can we merge this pull request ? since all the tests have passed. Thanks.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented May 24, 2023

I think the agreement in the WP4 / S&C meeting was to ask for official blessing by your PWG. @ddobrigk did you manage to follow that up? @hahassan7 could you alternatively have the convenors say a word on this thread?

@lhavener
Copy link
Copy Markdown

Hi @ktf, commenting as PWGJE conveners that we approve this commit. This is an important addition to the fast jet framework in order to do the background subtraction we need for our jet substructure measurements.

@ktf ktf merged commit 1cf518a into master May 25, 2023
@ktf ktf deleted the bump-fastjet branch May 25, 2023 15:08
@ktf
Copy link
Copy Markdown
Member Author

ktf commented May 25, 2023

@lhavener thanks. I have now added a team @alisw/pwgje and invited you there. Next time an update to fastjet is needed you will be automatically notified. Please let me know if anyone else should be added there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants