backport a Rivet fix to CMS_2013_I1223519.cc#4
Merged
ktf merged 1 commit intoalisw:alice/2.7.2from Feb 13, 2020
maireiphc:patch-1
Merged
backport a Rivet fix to CMS_2013_I1223519.cc#4ktf merged 1 commit intoalisw:alice/2.7.2from maireiphc:patch-1
ktf merged 1 commit intoalisw:alice/2.7.2from
maireiphc:patch-1
Conversation
The AliGenerator bundle fails to be compiled in its daily builds due to an ambiguity in one of the 335 CMS plugin analyses.
Rivet/analyses/pluginCMS/CMS_2013_I1223519.cc in 2.7.2
pluginCMS/CMS_2013_I1223519.cc:156:54: error: reference to 'Et' is ambiguous
vector<double> jetets; transform(jets, jetets, Et);
...
The issue has in fact been spotted a few months ago by the rivet authors and fix there for later version.
("Et" -> "Kin::Et") + ("biset" -> "std::bitset")
See official Rivet commits :
https://gitlab.com/hepcedar/rivet/commit/ced494d4016dde5dcd24567a276942fa0f64c446
https://gitlab.com/hepcedar/rivet/commit/0d5f91a4c8e66f5c6cbd7d231c73a46be9c7109a
maireiphc
added a commit
to alisw/alidist
that referenced
this pull request
Feb 13, 2020
After the fixes of the CMS_2013_I1223519.cc, upgrade Rivet tag version to get rivet complied again hopefully. See alisw/rivet#4
ktf
pushed a commit
to alisw/alidist
that referenced
this pull request
Feb 13, 2020
After the fixes of the CMS_2013_I1223519.cc, upgrade Rivet tag version to get rivet complied again hopefully. See alisw/rivet#4
Atlantic777
pushed a commit
to Atlantic777/alidist
that referenced
this pull request
Feb 25, 2020
After the fixes of the CMS_2013_I1223519.cc, upgrade Rivet tag version to get rivet complied again hopefully. See alisw/rivet#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AliGenerator bundle fails to be compiled in its daily builds due to an ambiguity in one of the 335 CMS plugin analyses.
Rivet/analyses/pluginCMS/CMS_2013_I1223519.cc in 2.7.2
pluginCMS/CMS_2013_I1223519.cc:156:54: error: reference to 'Et' is ambiguous
vector jetets; transform(jets, jetets, Et);
...
The issue has in fact been spotted a few months ago by the rivet authors and fix there for later version.
("Et" -> "Kin::Et") + ("biset" -> "std::bitset")
See official Rivet commits :
https://gitlab.com/hepcedar/rivet/commit/ced494d4016dde5dcd24567a276942fa0f64c446
https://gitlab.com/hepcedar/rivet/commit/0d5f91a4c8e66f5c6cbd7d231c73a46be9c7109a
After the merge to branch alisw/Rivet/2.7.2, a new tag should be enabled "2.7.2-alice4" and the alidist/rivet.sh updated accordingly.