Fix top-level ns-3 test wrapper to avoid mtp.h build failures#238
Draft
Fix top-level ns-3 test wrapper to avoid mtp.h build failures#238
mtp.h build failures#238Conversation
|
|
Copilot
AI
changed the title
[WIP] [ISSUE-229] Fix bug related to code functionality
Disambiguate point-to-point trace events and document the ns-3 test entrypoint
Mar 12, 2026
Open
…ntrypoint Co-authored-by: tianhao909 <48342395+tianhao909@users.noreply.github.com>
Collaborator
|
转@wtl0000的评论:
|
Co-authored-by: tianhao909 <48342395+tianhao909@users.noreply.github.com>
Co-authored-by: tianhao909 <48342395+tianhao909@users.noreply.github.com>
Copilot
AI
changed the title
Disambiguate point-to-point trace events and document the ns-3 test entrypoint
Add top-level ns-3 test wrapper for Mar 12, 2026
devices-point-to-point
Co-authored-by: tianhao909 <48342395+tianhao909@users.noreply.github.com>
Co-authored-by: tianhao909 <48342395+tianhao909@users.noreply.github.com>
Copilot
AI
changed the title
Add top-level ns-3 test wrapper for
Fix top-level ns-3 test wrapper to avoid Mar 13, 2026
devices-point-to-pointmtp.h build failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The documented
./scripts/build.sh -t ns3 devices-point-to-pointflow was not reliable from the repo root. In practice, the wrapper could fall into the SimAI extern ns-3 build path and trigger unrelatedmtptest compilation, surfacingns3/mtp.herrors that are not part of thedevices-point-to-pointsuite.What changed
-t|--testpath inscripts/build.sh./scripts/build.sh -c ns3 <suite>and point users to the correct test entrypointpoint-to-pointto the actual suite namedevices-point-to-pointns-3 source selection
ns-3-alibabacloud/simulationns-3-alibabacloudif the submodule is missing locallyAvoid unrelated
mtpfailurescore,network,stats,point-to-point,testmtpand fail onns3/mtp.htest.pywith--no-buildafter the targeted build stepDocs
Example:
Invalid usage is now handled explicitly:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.