Skip to content

add initializer interface for php sdk when createFunction and updateF… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rsonghuster merged 1 commit into from
Oct 10, 2018
Merged

add initializer interface for php sdk when createFunction and updateF… #1

rsonghuster merged 1 commit into from
Oct 10, 2018

Conversation

@Arlenmbx
Copy link
Collaborator

@Arlenmbx Arlenmbx commented Sep 16, 2018

  • Add initalizer interface.
  • Add unit test.
  • Update readme.

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Arlenmbx Arlenmbx force-pushed the add-initializer-interface-for-php7-sdk branch from dcf06b0 to 57d164c Compare October 6, 2018 17:11
@coveralls
Copy link

coveralls commented Oct 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 44

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.356%
Totals Coverage Status
Change from base Build 36: 0.1%
Covered Lines: 204
Relevant Lines: 239
💛 - Coveralls

rsonghuster
rsonghuster reviewed Oct 8, 2018
View reviewed changes
README.md Outdated
'functionName' => $functionName,
'handler' => 'index.handler',
'initializer' => 'index.initializer',
'runtime' => 'php7',
Copy link
Collaborator

@rsonghuster rsonghuster Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个已经改成了php7.2了吧，你rebase一下？

@Arlenmbx Arlenmbx force-pushed the add-initializer-interface-for-php7-sdk branch from 5a7d73e to 63df463 Compare October 8, 2018 07:30
@rsonghuster rsonghuster added approved review sucess invalid This doesn't seem right and removed approved review sucess invalid This doesn't seem right labels Oct 10, 2018
@Arlenmbx Arlenmbx force-pushed the add-initializer-interface-for-php7-sdk branch from 63df463 to 8e2dfa3 Compare October 10, 2018 06:36
@rsonghuster rsonghuster added the approved review sucess label Oct 10, 2018
@rsonghuster rsonghuster merged commit 253e46e into master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsonghuster rsonghuster rsonghuster left review comments

Assignees

No one assigned

Labels

approved review sucess

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Arlenmbx @CLAassistant @coveralls @rsonghuster