Skip to content

Conversation

@zhangyxapp
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wb-zyx597643 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

_collapse(oldEdges) {
let columns = _.get(this.options, '_columns', []);
// 获取所有columns的宽度总和 加border
let width = getWidth(columns) + 2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开一个常量const BORDER_WIDTH = 2;

let titleRender = _.get(this, 'options._config.titleRender');
let titleDom = $(`<div class="title"></div>`);
let columns = _.get(this.options, '_columns', []);
let width = getWidth(columns) - 86;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

86是啥?最好加个注释或者常量

src/index.less Outdated
line-height: 8px;
font-weight: 900;
cursor: pointer;
z-index: 999;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样设置可能不太好,这个我会来设置的。

@noonnightstorm noonnightstorm merged commit 2cb0297 into aliyun:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants