Skip to content

fix: getNestedTree with Model::shouldBeStrict() #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HassanDomeDenea wants to merge 1 commit into from
Closed

fix: getNestedTree with Model::shouldBeStrict() #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Models/Taxonomy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ protected static function buildNestedTree(Collection $taxonomies): Collection
} else {
// Child level - add to parent's children collection
$parent = end($stack);
if ($parent && ! $parent->children_nested) {
if ($parent && empty($parent->children_nested)) {
/** @var \Illuminate\Database\Eloquent\Collection<int, static> $childrenNested */
$childrenNested = new Collection;
$parent->setAttribute('children_nested', $childrenNested);
Expand Down
7 changes: 7 additions & 0 deletions tests/Feature/NestedSetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
use Aliziodev\LaravelTaxonomy\Enums\TaxonomyType;
use Aliziodev\LaravelTaxonomy\Models\Taxonomy;
use Aliziodev\LaravelTaxonomy\Tests\TestCase;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Foundation\Testing\RefreshDatabase;

uses(TestCase::class, RefreshDatabase::class);
Expand Down Expand Up @@ -328,3 +329,9 @@ function createTestTaxonomies(): void
expect($techTag->isAncestorOf($electronics))->toBeFalse();
expect($electronics->isAncestorOf($techTag))->toBeFalse();
});

it('works when models are strict', function () {
Model::shouldBeStrict();
$tree = Taxonomy::getNestedTree(TaxonomyType::Category);
expect($tree)->toHaveCount(2);
});
Loading