Skip to content

feat: Add gitmoji option to commitConventions#205

Merged
Berkmann18 merged 2 commits into
all-contributors:masterfrom
SnO2WMaN:feature/add-gitmoji-to-commitconvention
Sep 4, 2019
Merged

feat: Add gitmoji option to commitConventions#205
Berkmann18 merged 2 commits into
all-contributors:masterfrom
SnO2WMaN:feature/add-gitmoji-to-commitconvention

Conversation

@SnO2WMaN
Copy link
Copy Markdown

@SnO2WMaN SnO2WMaN commented Sep 1, 2019

What:

Why:

#202

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Copy Markdown
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for contributing!
Could you also update https://github.com/all-contributors/all-contributors/blob/master/docs/cli/configuration.md?

Copy link
Copy Markdown
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for contributing!

Make sure all tests pass.

Also, could you also update https://github.com/all-contributors/all-contributors/blob/master/docs/cli/configuration.md?

@SnO2WMaN
Copy link
Copy Markdown
Author

SnO2WMaN commented Sep 4, 2019

Test is OK by #204. Thanks @simon300000 .

Copy link
Copy Markdown
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@Berkmann18 Berkmann18 merged commit 06bbb6e into all-contributors:master Sep 4, 2019
@Berkmann18
Copy link
Copy Markdown
Member

@all-contributors Please add @SnO2WMaN for code.

@allcontributors
Copy link
Copy Markdown
Contributor

@Berkmann18

I've put up a pull request to add @SnO2WMaN! 🎉

@all-contributors-release-bot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants